Skip to content

[FIX] Fix Sidebar is missing Project icons#38

Merged
martian56 merged 1 commit into
mainfrom
37-sidebar-is-missing-project-icons
Mar 20, 2026
Merged

[FIX] Fix Sidebar is missing Project icons#38
martian56 merged 1 commit into
mainfrom
37-sidebar-is-missing-project-icons

Conversation

@martian56
Copy link
Copy Markdown
Member

@martian56 martian56 commented Mar 20, 2026

This pull request introduces several improvements related to code formatting, consistency, and configuration for the project. The main changes include the addition of editor and Git attribute configuration files, standardization of code style (notably, switching to single quotes in JavaScript/TypeScript), and minor updates to documentation and versioning. These updates help ensure a consistent development environment and codebase style.

Project configuration and tooling:

  • Added a .editorconfig file to enforce consistent editor settings such as line endings, indentation, and character encoding across the project.
  • Added a .gitattributes file to standardize line endings and text handling for various file types, improving cross-platform compatibility.
  • Introduced a .prettierrc file in the ui directory to enforce code formatting rules (semi-colons, single quotes, print width).

Code style and consistency:

Documentation and config updates:

  • Updated code examples and import statements in ui/README.md to use single quotes for consistency with the codebase. [1] [2] [3]

Version bump:

  • Bumped the version of the ui package from 0.4.0 to 0.4.1 in both package.json and package-lock.json. [1] [2]

Closes #37

@martian56 martian56 added this to the Deadline milestone Mar 20, 2026
@martian56 martian56 self-assigned this Mar 20, 2026
@martian56 martian56 added the UI label Mar 20, 2026
Copilot AI review requested due to automatic review settings March 20, 2026 08:16
Comment thread ui/src/pages/CyclesPage.tsx Dismissed
Copy link
Copy Markdown
Contributor

Copilot AI left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pull request overview

This PR is intended to fix “Sidebar is missing Project icons” (closes #37), but the provided diffs primarily apply repo-wide formatting/tooling changes (single-quote normalization, line wrapping) with no clearly visible sidebar/icon logic changes.

Changes:

  • Add formatting/tooling configuration (.prettierrc, .editorconfig, .gitattributes) and apply widespread reformatting (quote style, wrapping).
  • Bump ui package version to 0.4.1.
  • Minor refactors that are primarily stylistic (condensing JSX/TS formatting) across UI pages, components, contexts, and services.

Reviewed changes

Copilot reviewed 148 out of 150 changed files in this pull request and generated 6 comments.

Show a summary per file
File Description
ui/vite.config.ts Quote/style-only changes in Vite config.
ui/tsconfig.json Condenses references formatting.
ui/src/utils/workspace.ts Quote/style-only changes.
ui/src/types/workspaceViewFilters.ts Quote/style-only changes + formatting compaction.
ui/src/types/workspaceViewDisplay.ts Quote/style-only changes + formatting compaction.
ui/src/types/index.ts Quote/style-only changes in union string literals.
ui/src/styles/tokens.css Formatting and quote style changes in CSS.
ui/src/services/workspaceService.ts Quote/style-only formatting in API calls.
ui/src/services/viewService.ts Quote/style-only formatting in API calls.
ui/src/services/userService.ts Quote/style-only formatting in API calls.
ui/src/services/uploadService.ts Quote/style-only changes; error string quoting.
ui/src/services/stickiesService.ts Quote/style-only formatting.
ui/src/services/stateService.ts Quote/style-only formatting.
ui/src/services/recentsService.ts Quote/style-only formatting.
ui/src/services/quickLinksService.ts Quote/style-only formatting.
ui/src/services/projectService.ts Quote/style-only formatting.
ui/src/services/pageService.ts Quote/style-only formatting.
ui/src/services/notificationService.ts Quote/style-only formatting.
ui/src/services/moduleService.ts Quote/style-only formatting.
ui/src/services/labelService.ts Quote/style-only formatting.
ui/src/services/issueService.ts Quote/style-only formatting.
ui/src/services/invitationService.ts Quote/style-only formatting.
ui/src/services/instanceService.ts Quote/style-only formatting.
ui/src/services/index.ts Quote/style-only changes to barrel exports.
ui/src/services/favoriteService.ts Quote/style-only formatting.
ui/src/services/cycleService.ts Quote/style-only formatting.
ui/src/services/commentService.ts Quote/style-only formatting.
ui/src/services/authService.ts Quote/style-only formatting.
ui/src/routes/ProtectedRoute.tsx Quote/style-only import changes.
ui/src/routes/InstanceAdminProtectedRoute.tsx Quote/style-only formatting.
ui/src/pages/setup/index.ts Quote/style-only changes to exports.
ui/src/pages/setup/InstanceSetupWelcomePage.tsx JSX formatting compaction + quote style changes.
ui/src/pages/setup/InstanceSetupConfigurePage.tsx Quote/style-only changes + JSX formatting compaction.
ui/src/pages/setup/InstanceSetupCompletePage.tsx JSX formatting compaction + quote style changes.
ui/src/pages/instance-admin/index.ts Quote/style-only changes to exports.
ui/src/pages/instance-admin/InstanceAdminWorkspacePage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/instance-admin/InstanceAdminLoginPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/instance-admin/InstanceAdminImagePage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/instance-admin/InstanceAdminGeneralPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/instance-admin/InstanceAdminCreateWorkspacePage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/instance-admin/InstanceAdminAuthenticationPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/instance-admin/InstanceAdminAIPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/index.ts Quote/style-only changes to exports.
ui/src/pages/ProjectsListPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/ProjectHomePage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/PagesPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/LoginPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/InviteSignUpPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/InviteAcceptPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/DraftsPage.tsx Quote/style-only import changes.
ui/src/pages/BoardPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/pages/ArchivesPage.tsx Quote/style-only import changes.
ui/src/pages/AnalyticsOverviewPage.tsx Quote/style-only changes + minor formatting compaction.
ui/src/main.tsx Quote/style-only changes.
ui/src/lib/viewFilterCount.ts Quote/style-only changes.
ui/src/lib/viewAccess.ts Quote/style-only changes.
ui/src/lib/utils.ts Quote/style-only changes.
ui/src/lib/slug.ts Quote/style-only changes.
ui/src/lib/projectViewsEvents.ts Quote/style-only changes.
ui/src/lib/projectSavedViewDisplay.ts Quote/style-only changes + formatting compaction.
ui/src/lib/moduleStatuses.ts Quote/style-only changes.
ui/src/lib/issueViewFavoritesEvents.ts Quote/style-only changes.
ui/src/lib/dateOnly.ts Quote/style-only changes.
ui/src/index.css Quote/style-only changes + formatting compaction.
ui/src/hooks/useModuleFavorites.ts Quote/style-only changes + formatting compaction.
ui/src/contexts/workspaceViewsStateContextRef.ts Quote/style-only changes + formatting compaction.
ui/src/contexts/useWorkspaceViewsState.ts Quote/style-only changes + formatting compaction.
ui/src/contexts/WorkspaceViewsStateProvider.tsx Quote/style-only changes + formatting compaction.
ui/src/contexts/WorkspaceViewsStateContext.tsx Quote/style-only changes to exports.
ui/src/contexts/ThemeContext.tsx Quote/style-only changes + formatting compaction.
ui/src/contexts/ProjectSavedViewDisplayContext.tsx Quote/style-only changes + formatting compaction.
ui/src/contexts/ModulesFilterContext.tsx Quote/style-only changes + formatting compaction.
ui/src/contexts/FavoritesContext.tsx Quote/style-only changes + formatting compaction.
ui/src/contexts/AuthContext.tsx Quote/style-only changes + formatting compaction.
ui/src/constants/workspace.ts Quote/style-only changes.
ui/src/config/env.ts Quote/style-only changes.
ui/src/components/workspace-views/index.ts Quote/style-only changes to exports.
ui/src/components/workspace-views/WorkspaceViewsLayoutSelector.tsx Quote/style-only changes + formatting compaction.
ui/src/components/workspace-views/WorkspaceViewsFiltersShared.tsx Quote/style-only changes + formatting compaction.
ui/src/components/workspace-views/WorkspaceViewsFiltersDropdown.tsx Quote/style-only import changes.
ui/src/components/workspace-views/WorkspaceViewsFiltersData.tsx Quote/style-only changes + formatting compaction.
ui/src/components/workspace-views/WorkspaceViewsEllipsisMenu.tsx Quote/style-only changes + formatting compaction.
ui/src/components/workspace-views/WorkspaceViewsDisplayPanel.tsx Quote/style-only changes + formatting compaction.
ui/src/components/workspace-views/WorkspaceViewsDisplayDropdown.tsx Quote/style-only changes + formatting compaction.
ui/src/components/workspace-views/DateRangeModal.tsx Quote/style-only changes + formatting compaction.
ui/src/components/workspace-views/CreateViewModal.tsx Quote/style-only changes + formatting compaction.
ui/src/components/work-item/index.ts Quote/style-only changes to exports.
ui/src/components/work-item/SelectParentModal.tsx Quote/style-only changes + formatting compaction.
ui/src/components/work-item/Dropdown.tsx Quote/style-only changes + formatting compaction.
ui/src/components/work-item/DatePickerTrigger.tsx Quote/style-only changes.
ui/src/components/work-item/CommentEditor.tsx Quote/style-only changes + formatting compaction.
ui/src/components/ui/index.ts Quote/style-only changes to exports.
ui/src/components/ui/Skeleton.tsx Quote/style-only changes + formatting compaction.
ui/src/components/ui/Modal.tsx Quote/style-only changes + formatting compaction.
ui/src/components/ui/Input.tsx Quote/style-only changes + formatting compaction.
ui/src/components/ui/Card.tsx Quote/style-only changes + formatting compaction.
ui/src/components/ui/Button.tsx Quote/style-only changes.
ui/src/components/ui/Badge.tsx Quote/style-only changes + formatting compaction.
ui/src/components/ui/Avatar.tsx Quote/style-only changes + formatting compaction.
ui/src/components/project-saved-view/ProjectSavedViewMoreMenu.tsx Quote/style-only changes + formatting compaction.
ui/src/components/project-saved-view/ProjectSavedViewDisplayDropdown.tsx Quote/style-only changes.
ui/src/components/layout/index.ts Quote/style-only changes to exports.
ui/src/components/layout/InstanceAdminLayout.tsx Quote/style-only changes + minor formatting compaction.
ui/src/components/layout/Header.tsx Quote/style-only changes + minor formatting compaction.
ui/src/components/layout/AppShell.tsx Quote/style-only changes.
ui/src/components/instance-admin/index.ts Quote/style-only changes to exports.
ui/src/components/instance-admin/CreateWorkspaceSetupHint.tsx JSX formatting compaction; behavior unchanged.
ui/src/components/UploadImageModal.tsx Quote/style-only changes + minor formatting compaction.
ui/src/components/UpdateModuleModal.tsx Quote/style-only changes + minor formatting compaction.
ui/src/components/SetupGate.tsx Quote/style-only changes.
ui/src/components/RootRedirect.tsx Quote/style-only changes + minor formatting compaction.
ui/src/components/ProjectNetworkSelect.tsx Quote/style-only changes + formatting compaction.
ui/src/components/ProjectLeadSelect.tsx Quote/style-only changes + formatting compaction.
ui/src/components/AddExistingWorkItemModal.tsx Quote/style-only changes + minor formatting compaction.
ui/src/api/types.ts Quote/style-only change in union literals.
ui/src/api/index.ts Quote/style-only changes to exports.
ui/src/api/client.ts Quote/style-only changes.
ui/src/App.tsx Quote/style-only import changes.
ui/package.json Bump UI version to 0.4.1.
ui/eslint.config.js Quote/style-only changes.
ui/README.md Quote/style-only changes in documentation snippets.
ui/.prettierrc Adds Prettier config (singleQuote, printWidth).
.gitattributes Normalizes line endings by file type.
.editorconfig Enforces consistent editor defaults (indent/eol).
Files not reviewed (1)
  • ui/package-lock.json: Language not supported

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

Comment thread ui/.prettierrc
Comment thread ui/package.json
Comment thread ui/src/components/instance-admin/CreateWorkspaceSetupHint.tsx
Comment thread ui/src/components/instance-admin/CreateWorkspaceSetupHint.tsx
Comment thread ui/src/components/UploadImageModal.tsx
Comment thread ui/src/api/types.ts
@martian56 martian56 merged commit 02cc20a into main Mar 20, 2026
7 checks passed
@martian56 martian56 deleted the 37-sidebar-is-missing-project-icons branch May 2, 2026 15:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

Projects

None yet

Development

Successfully merging this pull request may close these issues.

Sidebar is missing Project icons

2 participants